Reading File..Changing source type

[pc32402]

New to the board.. and its been many many many many many moons since I've done anything in basic so bear with me :-D

Bit off more than I should have with this one..

Have a friends kid that inherited a biz and wants to keep most things status quo...

The basic prog used was set up to use a data file then it delim'd by location i.e. [this is lifted from the code btw]

| | | | | Remarks (program ignores)
| | | | | |
| 0 1 2 3 3 4 4 4
1234567890123456789012345678901234567890123456789012345678901234567890

The problem came about when I was asked to help clean up, and add data; the code didn't have a sub to actually provide end user input..ergo the "instructions" in the data file... Unfortunately I can't jump up n down and haze the buddy that wrote it many many years ago. I will be perplexed until I meet him in the great beyond!

Manually imputing the data into the dat file proved to be troublesome and never 'lined up'.. SO I said OOO no big deal We'll just update it to read csv data....urggg

Now I've searched for some decent refreshers.. just a little pushed for time this week..

This is the old code..

Sub ReadCustFile
open theDir$+"\CUSTNAMES.DAT" for input as #f
numCUST=0
while not(eof(#f))
line input #f, dummy$
i=val(left$(dummy$,3))
if i>0 and i<11 and val(mid$(dummy$,43,1))>0 then
numCust=numTrains+1
custname$(i)=mid$(dummy$,5,29)
custcode$(i)=trim$(mid$(dummy$, 35,4))
custcap(i)=val(mid$(dummy$,40,2))
custclass(i)=val(mid$(dummy$,43,1))
' print dummy$
end if
wend
close #f
end sub

Any help in adapting it to read CSV.. ANY help or direction would be Immensely appreciated..

[jarych]

Jul 5, 2022 22:35:45 GMT pc32402 said:

New to the board.. and its been many many many many many moons since I've done anything in basic so bear with me :-D

Bit off more than I should have with this one..

Have a friends kid that inherited a biz and wants to keep most things status quo...

The basic prog used was set up to use a data file then it delim'd by location i.e. [this is lifted from the code btw]

| | | | | Remarks (program ignores)
| | | | | |
| 0 1 2 3 3 4 4 4
1234567890123456789012345678901234567890123456789012345678901234567890

The problem came about when I was asked to help clean up, and add data; the code didn't have a sub to actually provide end user input..ergo the "instructions" in the data file... Unfortunately I can't jump up n down and haze the buddy that wrote it many many years ago. I will be perplexed until I meet him in the great beyond!

Manually imputing the data into the dat file proved to be troublesome and never 'lined up'.. SO I said OOO no big deal We'll just update it to read csv data....urggg

Now I've searched for some decent refreshers.. just a little pushed for time this week..

This is the old code..

Sub ReadCustFile
open theDir$+"\CUSTNAMES.DAT" for input as #f
numCUST=0
while not(eof(#f))
line input #f, dummy$
i=val(left$(dummy$,3))
if i>0 and i<11 and val(mid$(dummy$,43,1))>0 then
numCust=numTrains+1
custname$(i)=mid$(dummy$,5,29)
custcode$(i)=trim$(mid$(dummy$, 35,4))
custcap(i)=val(mid$(dummy$,40,2))
custclass(i)=val(mid$(dummy$,43,1))
' print dummy$
end if
wend
close #f
end sub

Any help in adapting it to read CSV.. ANY help or direction would be Immensely appreciated..

Your subroutine indicates that each variable value (arrays) from the file is its own specific length.  Not easy know if that kind of restriction is necessary.    What kind of information is put into the variables custcode$(), custcap(), and custclass() ?  What exactly is your objective?  Just to open and read the file?

[tsh73]

pc32402,
give us some 3 lines from data file so we could see what being read
Post it in [ code ] tags (button with C on a toolbar) so spaces will not be lost
(btw if program had indenting you might want it to be reposted in [ code ] tags as well)

Make sample SCV file for testing, post it here/ Again 3 lines should be enough.

[jarych]

This example code should help, even that there is some output formatting trouble, but this will open a text file (csv) to read it for input, and then display the information in tabular form.
First make and put this text file as named into your program's default location - the same directory of the example program:

Give this txt file the name, pianomencsv.txt:

littlerich,macon,1932
fatsdom,new orleans,1928
jerry,ferriday,1935
proflonghair,bogalusa,1918
Dr. John,new orleans,1941


'csv simple example, to open and read csv file
'name this program boogiecsv.bas
'use the file pianomencsv.txt, 5 rows by 3 columns

'VARIABLES
dim who$(15,3)
name$=""         'name of player
bwhere$=""       'born where
byear$=""        'born what year
'i0=0            'loop variable
i1=0            'loop variable
rec=0           'record counter for how many persons

'OPEN THE FILE, LOAD THE ARRAY, CLOSE THE FILE
open "pianomencsv.txt" for input as #pno
   while eof(#pno)=0
   input #pno,name$
   input #pno,bwhere$
   input #pno,byear$
   rec=rec+1
   who$(rec,1)=name$
   who$(rec,2)=bwhere$
   who$(rec,3)=byear$
   wend
close #pno

'DISPLAY ARRAY RECORDS
gosub [showwhodata]

'REINITIALIZE PROCESS VARIABLES
gosub [reinitialize]

END

[showwhodata]
print "We identified your ";rec;" piano players."
print
print "PIANO MAN","WHERE BORN","YEAR BORN"
for i0=1 to rec
   print who$(i0,1),who$(i0,2),who$(i0,3)
next i0
return

[reinitialize]
name$=""
bwhere$=""
byear$=""
rec=0
return



[Rod]

If the original data is fixed width then you are never going to get it back with CSV code. You need to stick to fixed width and find out why it is not lining up. There may be header info in the file. As tsh73 says show us the start of the real file and give us a clue as to what you expect it to mean. The example code you post is relatively straight forwards.

If you want to add data to a fixed width file add it at the end and use new location values to use it.