b+ Battleship

[plus]

Thanks to tsh73 inspiring version of Battleship I decided to port my version from QB64. It was loaded with sound and image assets for graphics screen but I thought it fun to do a basic b&w version of JB's mainwin screen for the challenge. Yikes! the difference in editors, what a challenge to do so many LOC, ~500, in JB's editor, you do allot of scrolling looking for routines!!!
I hit one of those mysterious bugs when JB gives you not a clue what is wrong. I forgot where the useless error log is, Roaming data somewhere, but I can't find it in Windows Explorer blah! So I just started rebuilding the code adding one routine at a time until I hit the error again, no () allowed in a Sub definition! What a screwy error message you get for that! Anyway figured it out and here is working Battleship game based on Hasbro version.

Some instructions for those unfamiliar with game, Where I say squares I mean character cells:

The object of the game is to sink all the Computer's ships before it sinks all yours.

Both the Player and the Computer are given 5 ships to lay out on a 10x10 grid.

The ships are a straight line of squares (2 to 5 squares) forming a long rectangle.
The ships are laid vertically or horizontally on the 10x10 cell grid without overlap.
Each square must be hit by the opponent in order to sink the ship.

The 5 ships are:
Carrier - 5 squares to hit
Battleship - 4 squares to hit
Cruiser - 3 squares to hit
Submarine - 3 squares to hit
Destroyer - 2 squares to hit

The game is started by each opponent laying out their ships secretly to the other.
You the Player must setup your ships on the left board.
They are setup in same order I listed above.

If you do not want the computer to setup for you:
So the first ship to set up will be the Carrier that is 5 squares long.
Enter v or h for horizontal or vertical then the column letter don't worry about capitals then
the digit 0 to 9. So that is 3 chraracters the first v or h, the 2nd abcdefghi or j and 3rd
is 0 to 9. Be careful not to click other places on board because printing will start there
and mess up board.

If there is room on board to lay out all 5 across AND this ship does not overlap another,
then the rest of the ship will be drawn in with its numbers 1 - 5 for the player. The computers
ship numbers are 6-10 but 10 is shown as 0 (after you lose and the comnputers ship placement is
displayed, you can see these before next game is started.)
(Of course, the first ship can't overlap another but every other ship has that potential.)
If there is not room or the ship would overlap another,
then you must start over with the prompt to lay the ship horizontally or vertically...

When you get all 5 of your ships laid out on the 10x10 grid on the left, the shooting match begins!

You will be prompted to Enter a cell on the right 10x10 board to guess where a Computer's ship might be.
If you hit a cell of the Computers ships an X for hit appears at that cell.
If you miss all the Computers ships, an O will appear = miss

The Computer will then take a shot and your board will show an X or O according to the Computer's hit or miss.

Then it's your turn again. If you had a hit the last turn you will likely want to find the
rest of the ship to sink it. So Enter cells above, below, left or right of the hit.
A 2nd hit will tell you if the ship is laid out horizontally or vertically.
A 2nd hit would actually sink a Destroyer because it is only 2 squares long.

So you scout around the 10x10 board making random shots (or systematically cover the board with shots)
until you find a ship, sink it and go hunting for the next ship to sink until you get all 5.

Meanwhile the Computer is doing the same thing, so whichever opponent sinks all the ships first, wins!

Oh a caveat!
It is possible to align the ships side by side or one end up next to another ship
(as long as they don't overlap). This makes it confusing as you might be hitting 2 different ships
with your shots, so pay close attention to which ship is announced sunk, you might have more hits
in the same area than how many it took to sink the ship.

en.wikipedia.org/wiki/Battleship_game

And the game:
' Battleship based on Hasbro Game b+ 2024-07-23 allot of code ported out of old QB64 version

Global PXO, PYO, CXO, CYO, SXO, SYO ' see setup where these are set with Game Board
Global dir, rI, rMax, currentHits, pTurn, GameOn ' preserve between AI calls
Global x1, y1, bombx, bomby, hit2
while 1
   scan
   call Setup
   call Shoot
wend

sub Setup
   ' clear arrays and variables
   dim shipX(10), shipY(10), shipLen(10), shipName$(10), shipHor(10), shipHits$(10), shipSunk(10) ' not using 0 index
   dim p(9, 9), c(9, 9)
   ' for Computer AI
   dim hits(9, 9), rX(100), rY(100)
   dir = 0: rI = 0: rMax = 0: currentHits = 0: pTurn = 0: GameOn = 0 ' globals
   'setup random bombing locations
   For y = 0 To 9
       If y Mod 2 = 0 Then startX = 1 Else startX = 0
       For x = startX To 9 Step 2
           rX(rI) = x: rY(rI) = y: rI = rI + 1
       Next
   Next
   'now shuffle the coverage for random luck at finding first hits
   rMax = rI - 1
   For i = rMax To 1 Step -1
       r = Int(Rnd(0) * (i + 1))
       t = rX(i) : rX(i) = rX(r) : rX(r) = t
       t = rY(i) : rY(i) = rY(r) : rY(r) = t
   Next
   rI = 0
   cls
   ' Game Board draw once per game
   Print ""
   Print "          Player                    Computer"
   Print ""
   Print "    A B C D E F G H I J        A B C D E F G H I J"
   Print "    -------------------        -------------------"
   Print " 0| . . . . . . . . . .     0| . . . . . . . . . ."
   Print " 1| . . . . . . . . . .     1| . . . . . . . . . ."
   Print " 2| . . . . . . . . . .     2| . . . . . . . . . ."
   Print " 3| . . . . . . . . . .     3| . . . . . . . . . .   Ships:     P C"
   Print " 4| . . . . . . . . . .     4| . . . . . . . . . .   Carrier    . ."
   Print " 5| . . . . . . . . . .     5| . . . . . . . . . .   Battleship . ."
   Print " 6| . . . . . . . . . .     6| . . . . . . . . . .   Cruiser    . ."
   Print " 7| . . . . . . . . . .     7| . . . . . . . . . .   Submarine  . ."
   Print " 8| . . . . . . . . . .     8| . . . . . . . . . .   Destroyer  . ."
   Print " 9| . . . . . . . . . .     9| . . . . . . . . . ."
   Print "    -------------------        -------------------"
   Print "    A B C D E F G H I J        A B C D E F G H I J"
   'locate 5, 6: print "X" ' check offsets
   PXO = 5  : PYO = 6 ' offsets for player grid
   CXO = 32 : CYO = 6 ' offsets for computer grid player shoots at
   SXO = 65 : SYO = 10 ' offsets ship tally

   For i = 1 To 10 ' not sure I need names yet
       Select Case i
           Case 1: shipLen(i) = 5: shipName$(i) = "Carrier"
           Case 2: shipLen(i) = 4: shipName$(i) = "Battleship"
           Case 3: shipLen(i) = 3: shipName$(i) = "Cruiser"
           Case 4: shipLen(i) = 3: shipName$(i) = "Submarine"
           Case 5: shipLen(i) = 2: shipName$(i) = "Destroyer"

           Case 6: shipLen(i) = 5: shipName$(i) = "Carrier"
           Case 7: shipLen(i) = 4: shipName$(i) = "Battleship"
           Case 8: shipLen(i) = 3: shipName$(i) = "Cruiser"
           Case 9: shipLen(i) = 3: shipName$(i) = "Submarine"
           Case 10: shipLen(i) = 2: shipName$(i) = "Destroyer"
       End Select
   Next
   For i = 1 To 10
       shipHits$(i) = String$(shipLen(i), "o")
   Next
   call autosetup 1
   call message "Let computer setup your ships?  press y for yes, n for no..."
   k$ = Input$(1)
   If k$ = "y" Then
       call autosetup 0
   Else
       For S = 1 To 5
           OK = 0
           locate 1, 21
           print "To place ship:"+chr$(13)+"Enter v for vertical, h for horizontal, letter and digit for top, left of ship"
           While OK = 0
               call clearMessage
               call message "Setting up the ";shipName$(S);" with length ";shipLen(S)
               Locate 1, 23: Print Space$(80);
               locate 1, 23: input "placement? "; place$
               place$ = upper$(place$)
               If Left$(place$, 1) = "V" Then shipHor(S) = 0 Else shipHor(S) = 1
               sx = InStr("ABCDEFGHIJ", Mid$(place$, 2, 1)) -1
               sy = val(mid$(place$, 3, 1))
               locate 1, 23: print space$(80);
               If shipHor(S) Then
                   If sx <= 10 - shipLen(S) Then
                       OK = 1
                       For xx = 0 To shipLen(S) - 1
                           If p(sx + xx, sy) <> 0 Then OK = 0: Exit For
                       Next
                       If OK Then
                           shipX(S) = sx: shipY(S) = sy
                           For xx = 0 To shipLen(S) - 1
                               p(sx + xx, sy) = S
                               call LP sx + xx, sy, "p", str$(S)
                           Next
                       End If
                   End If
               Else
                   If sy <= 10 - shipLen(S) Then
                       OK = 1
                       For yy = 0 To shipLen(S) - 1
                           If p(sx, sy + yy) <> 0 Then OK = 0: Exit For
                       Next
                       If OK Then
                           shipX(S) = sx: shipY(S) = sy
                           For yy = 0 To shipLen(S) - 1
                               p(sx, sy + yy) = S
                               call LP sx, sy + yy, "p", str$(S)
                           Next
                       End If
                   End If
               End If
           Wend
       Next
       locate 1, 21: print space$(80);
       locate 1, 22: print space$(80);
       locate 1, 23: print space$(80);
   End If
   call clearMessage
end sub

Sub autosetup AItf '  there is surely a shorter way to do this but I am eager to get on with other stuff
   If AItf Then 'setup Computer's ships
       'setup a board with ships, Computer or AI's setup
       For S = 6 To 10
           OK = 0
           While OK = 0
               shipHor(S) = rand(0, 1)
               If shipHor(S) Then
                   sy = rand(0, 9)
                   sx = rand(0, 10 - shipLen(S))
                   OK = 1
                   For xx = 0 To shipLen(S) - 1
                       If c(sx + xx, sy) <> 0 Then OK = 0: Exit For
                   Next
                   If OK Then
                       shipX(S) = sx: shipY(S) = sy
                       For xx = 0 To shipLen(S) - 1
                           c(sx + xx, sy) = S
                           'call LP sx + xx, sy, "c", str$(S mod 10) ' for debugg
                       Next
                   End If
               Else
                   sx = rand(0, 9)
                   sy = rand(0, 10 - shipLen(S))
                   OK = 1
                   For yy = 0 To shipLen(S) - 1
                       If c(sx, sy + yy) <> 0 Then OK = 0: Exit For
                   Next
                   If OK Then
                       shipX(S) = sx: shipY(S) = sy
                       For yy = 0 To shipLen(S) - 1
                           c(sx, sy + yy) = S
                           'call LP sx, sy + yy, "c", str$(S mod 10) ' for debugg
                       Next
                   End If
               End If
           Wend
       Next
   Else 'setup Player's ships
       For S = 1 to 5
           OK = 0
           While OK = 0
               shipHor(S) = rand(0, 1)
               If shipHor(S) Then
                   sy = rand(0, 9)
                   sx = rand(0, 10 - shipLen(S))
                   OK = 1
                   For xx = 0 To shipLen(S) - 1
                       If p(sx + xx, sy) <> 0 Then OK = 0: Exit For
                   Next
                   If OK Then
                       shipX(S) = sx: shipY(S) = sy
                       For xx = 0 To shipLen(S) - 1
                           p(sx + xx, sy) = S
                           call LP sx + xx, sy, "p", str$(S)
                       Next
                   End If
               Else
                   sx = rand(0, 9)
                   sy = rand(0, 10 - shipLen(S))
                   OK = 1
                   For yy = 0 To shipLen(S) - 1
                       If p(sx, sy + yy) <> 0 Then OK = 0: Exit For
                   Next
                   If OK Then
                       shipX(S) = sx: shipY(S) = sy
                       For yy = 0 To shipLen(S) - 1
                           p(sx, sy + yy) = S
                           call LP sx, sy + yy, "p", str$(S)
                       Next
                   End If
               End If
           Wend
       Next
   End If
End Sub

sub message m$
   locate 1, 20: print m$;
end sub

sub clearMessage
   locate 1, 20: print space$(80);
   locate 1, 20: print ""
end sub

sub LP x, y, pcGrid$, s$
if pcGrid$ = "p" then locate PXO + 2 * x, PYO + y else locate CXO + 2 * x, CYO + y
Print s$;
end sub

function rand(low, high) ' Random integer from low to high inclusive
   rand = int(rnd(0) * (high - low + 1)) + low
end function

sub Shoot
   GameOn = 1
   While GameOn
       scan
       'call updateStatus ' really needed here?
       If pTurn Then pTurn = 0 Else pTurn = 1
       If pTurn Then
           Locate 1, 20: Input "Enter your next bomb site letter digit "; place$
           If place$ = "" Then GameOn = 0
           place$ = upper$(place$)
           bx = instr("ABCDEFGHIJ", left$(place$, 1)) - 1
           by = val(mid$(place$, 2, 1))
           if bx >= 0 and bx < 10 then ' better check
               if by >= 0 and by < 10 then
                   If c(bx, by) <> 0 Then 'hit
                       call LP bx, by, "c", "X"
                       call hitEval "c", bx, by 'game could end here
                   Else
                       call LP bx, by, "c", "o"
                   End If
               end if
           end if
           call clearMessage
       Else
           'AI's turn if it gets a hit it will bomb around the ship until it is finished
           'could be trouble if 2 ships are next to each other, damn until just now I hadn't anticipated this
           'hits board tracks red and white pegs like a human player for AI
           While hits(cx(checkIndex), cy(checkIndex)) <> 0
               checkIndex = checkIndex - 1
               If checkIndex <= 0 Then checkIndex = 0: Exit While
           Wend
           If dir Then 'we have a bomb location all set to test
               If p(bombx, bomby) <> 0 Then 'hit!
                   hit2 = 1
                   hits(bombx, bomby) = 1: currentHits = currentHits + 1
                   call LP bombx, bomby, "p", "X"

                   'we need to know stuff but can't use this info for AI finding the ship
                   'when hitEval announces a ship sunk we can reduce the currentHits count by that ships amount
                   'if still have more current hits, continue bombing area as another ship is there
                   call hitEval "p", bombx, bomby 'this will reduce currentHits by the amount a ship could take when sunk
                   If currentHits = 0 Then 'clear our checklist we sank all ships we hit, call off bombing of area
                       x1 = 0: y1 = 0: dir = 0
                   Else
                       call decideWhereToBombNext
                   End If
               Else 'no hit from checklist scratch off one item
                   hit2 = 0
                   hits(bombx, bomby) = -1
                   call LP bombx, bomby, "p", "o"
                   call decideWhereToBombNext
               End If ' are we still working on hit

           Else
               'not working on any hits x1, y1 = 0, dir = 0, currentHits might be = 0
               'random but systematic shooting, bring up next good shooting location
               While hits(rX(rI), rY(rI)) <> 0
                   rI = rI + 1
                   'if rI exceeds rMax then hits is loaded
               Wend
               'consider that shot just fired was it a hit or miss
               If p(rX(rI), rY(rI)) <> 0 Then ' test our shot just fired is hit!
                   x1 = rX(rI): y1 = rY(rI) 'save first hit to come back to
                   hits(x1, y1) = 1: currentHits = currentHits + 1
                   call LP x1, y1, "p", "X"
                   'we need to know stuff but can't use this info for AI finding the ship
                   'it's the same as for the player
                   call hitEval "p", x1, y1
                   'did we just happen to finish off a ship?  current hits = 0
                   If currentHits = 0 Then 'must of finished off an ship
                       x1 = 0: y1 = 0: dir = 0 'we are done
                   Else
                       dir = -1
                       call decideWhereToBombNext
                   End If
               Else 'no hit
                   hits(rX(rI), rY(rI)) = -1
                   call LP rX(rI), rY(rI), "p", "o"
               End If

               rI = rI + 1 'we used rI so get next bomb index ready
               If rI > rMax Then 'reload with next set of coodinates
                   rI = 0
                   For y = 0 To sqPerSide - 1
                       If y Mod 2 = 0 Then startX = 0 Else startX = 1
                       For x = startX To sqPerSide - 1 Step 2
                           rX(rI) = x: rY(rI) = y: rI = rI + 1
                       Next
                   Next
                   'now shuffle the coverage for random luck at finding first hits
                   rMax = rI - 1
                   For i = rMax To 1 Step -1
                       r = Int(Rnd(0) * (i + 1))
                       t = rX(i) : rX(i) = rX(r) : rX(r) = t
                       t = rY(i) : rY(i) = rY(r) : rY(r) = t
                   Next
                   rI = 0
               End If 'getting rI ready
           End If 'rI was hit or not
       End If 'whose turn is it
   Wend
   call message "Play Again? press y for yes, n for no..."
   k$ = input$(1)
   cls
   if k$ = "n" then end
end sub

Sub hitEval board$, bbx, bby
   'this is like a referee / judge for both players  to announce a ship sunk and a game won?
   'notice "hitEval"+chr$(13)+board$+", bx,by" + str$(bbx) +", "+str$(bby)
   If board$ <> "p" Then
       S = c(bbx, bby) ' which ship number
       you$ = "Player"
       my$ = "Computer's"
       istart = 6
       istop = 10
   Else
       S = p(bbx, bby)
       you$ = "Computer"
       my$ = "Player's"
       istart = 1
       istop = 5
   End If
   If shipHor(S) Then d = bbx - shipX(S) + 1 Else d = bby - shipY(S) + 1
   'notice "s d = "+chr$(13) + str$(S) + ", "+str$(d)
   shipHits$(S) = SubStr$(shipHits$(S), d, "X")
   'notice "shipHits$ S"+Chr$(13)+shipHits$(S) + " "+str$(S)
   If shipHits$(S) = String$(shipLen(S), "X") Then
       shipSunk(S) = 1
       If board$ = "p" Then currentHits = currentHits - shipLen(S)
       call updateStatus
       notice you$ + " sank " + my$ + " " + shipName$(S); "!"
       tot = 0
       For i = istart To istop
           If shipSunk(i) = 1 Then tot = tot + 1
       Next
       If tot = 5 Then
           call updateStatus
           if you$ = "Computer" then call ShowComputersShips
           Notice "Congratulations " + you$ + ", you sank all " + my$ + " ships! GameOver..."
           GameOn = 0
       End If
   End If
End Sub

Sub decideWhereToBombNext
   'find next good location, mark the direction we took
   If dir = -1 Then '    we just got a fresh hit the rest of the ship is in 1 of 4 directions
       hit2 = 0 'when direction = 0 reset 2nd hit signal to 0
       If x1 + 1 <= 9 Then
           If hits(x1 + 1, y1) = 0 Then
               bombx = x1 + 1: bomby = y1: dir = 1: Exit Sub
           End If
       End If
       'still here?
       If y1 + 1 <= 9 - 1 Then
           If hits(x1, y1 + 1) = 0 Then
               bombx = x1: bomby = y1 + 1: dir = 2: Exit Sub
           End If
       End If
       'still here?
       If x1 - 1 >= 0 Then
           If hits(x1 - 1, y1) = 0 Then
               bombx = x1 - 1: bomby = y1: dir = 3: Exit Sub
           End If
       End If
       'still here OK this has to do it!
       If y1 - 1 >= 0 Then
           If hits(x1, y1 - 1) = 0 Then
               bombx = x1: bomby = y1 - 1: dir = 4: Exit Sub
           End If
       End If
       'still here ???? damn! give up and go back to random shots
       dir = 0: Exit Sub '   <    this signals that
   End If

   'setup next bombx, bomby
   If hit2 Then 'whatever direction we are taking, continue if we can
       Select Case dir
           Case 1
               If bombx + 1 <= 9 Then
                   If hits(bombx + 1, bomby) = 0 Then
                       bombx = bombx + 1: Exit Sub
                   End If
               End If
           Case 2
               If bomby + 1 <= 9 Then
                   If hits(bombx, bomby + 1) = 0 Then
                       bomby = bomby + 1: Exit Sub
                   End If
               End If
           Case 3
               If bombx - 1 >= 0 Then
                   If hits(bombx - 1, bomby) = 0 Then
                       bombx = bombx - 1: Exit Sub
                   End If
               End If
           Case 4
               If bomby - 1 >= 0 Then
                   If hits(bombx, bomby - 1) = 0 Then
                       bomby = bomby - 1: dir = 4: Exit Sub
                   End If
               End If
       End Select
   End If

   'still here? then we have to change direction  and go back to x1, y1 the first hit
   hit2 = 0 'reset this for the new direction check
   While dir < 4
       dir = dir + 1
       Select Case dir
           Case 2
               If y1 + 1 <= 9 Then
                   If hits(x1, y1 + 1) = 0 Then
                       bombx = x1: bomby = y1 + 1: Exit Sub
                   End If
               End If
           Case 3
               If x1 - 1 >= 0 Then
                   If hits(x1 - 1, y1) = 0 Then
                       bombx = x1 - 1: bomby = y1: Exit Sub
                   End If
               End If
           Case 4
               If y1 - 1 >= 0 Then
                   If hits(x1, y1 - 1) = 0 Then
                       bombx = x1: bomby = y1 - 1: Exit Sub
                   End If
               End If
       End Select
   Wend
   'still here, well we've run out of directions
   dir = 0 'back to random bombing
End Sub

function SubStr$(s$, place, subst$)
   for i = 1 to len(s$)
       if i = place then r$ = r$ + subst$ else r$ = r$ + mid$(s$, i, 1)
   next
   SubStr$ = r$
end function

function String$(number, s$)
   for i = 1 to number
       r$ = r$ + s$
   next
   String$ = r$
end function

Sub updateStatus ' ships area
   For i = 1 To 5 ' row 10 carrier player colum 66 computer column 68
       If shipSunk(i) Then Locate 65, i + 9:  Print "X";
       If shipSunk(i + 5) Then Locate 67, i + 9: Print "X"
   Next
End Sub

sub ShowComputersShips
   For S = 6 To 10
       If shipHor(S) Then
           sx = shipX(S): sy = shipY(S)
           For xx = 0 To shipLen(S) - 1
               call LP sx + xx, sy, "c", str$(S mod 10) ' for debugg
           Next
       Else
           sx = shipX(S) : sy = shipY(S)
           For yy = 0 To shipLen(S) - 1
               call LP sx, sy + yy, "c", str$(S mod 10) ' for debugg
           Next
       End If
   Next
end sub


BTW You are in luck! I ported from the dumber AI version I made thinking there would be less code fixes for the JB version.
The smarter version ends a game long before 50% of cells have been bombed, just over 1/3 approximately on average.


b = b + ...

[tsh73]

Oh, this dumb AI outsmart me :(

Some feedback where AI fired at would be nice.

[plus]

Yeah can insert a delay so after you enter your shot you can watch for movement on your board. I just type in my shot then put my eyes on the Player board and watch for movement when I press enter for my shot
or we can barrow your trick of changing big O for o before next play of AI.

Here is stats I did between mod 2 AI does checkered fire pattern over board and mod 3 AI that skips 2 cells along each row, hoping to nab the Destroyer by luck along the way.

ai2 ai3 wins out of 100 ai playing ai
47 53
47 53
52 48
36 64
41 59

b = b + ...

[plus]

Yeah I think this AI is slightly better! (comments are not all updated)
' Battleship 2 stronger AI 2024-07-24
' based on Hasbro Game b+ 2024-07-23 allot of code ported out of old QB64 version

Global PXO, PYO, CXO, CYO, SXO, SYO ' see setup where these are set with Game Board
Global dir, currentHits, pTurn, GameOn ' preserve between AI calls
Global x1, y1, bombx, bomby, hit2, ColA, col, row, bump, ihit, rehit
PXO = 5  : PYO = 6 ' offsets for player grid
CXO = 32 : CYO = 6 ' offsets for computer grid player shoots at
SXO = 65 : SYO = 10 ' offsets ship tally
dim shipLen(10), shipName$(10)
For i = 1 To 10 ' not sure I need names yet
   Select Case i
       Case 1: shipLen(i) = 5: shipName$(i) = "Carrier"
       Case 2: shipLen(i) = 4: shipName$(i) = "Battleship"
       Case 3: shipLen(i) = 3: shipName$(i) = "Cruiser"
       Case 4: shipLen(i) = 3: shipName$(i) = "Submarine"
       Case 5: shipLen(i) = 2: shipName$(i) = "Destroyer"
       Case 6: shipLen(i) = 5: shipName$(i) = "Carrier"
       Case 7: shipLen(i) = 4: shipName$(i) = "Battleship"
       Case 8: shipLen(i) = 3: shipName$(i) = "Cruiser"
       Case 9: shipLen(i) = 3: shipName$(i) = "Submarine"
       Case 10: shipLen(i) = 2: shipName$(i) = "Destroyer"
   End Select
Next
while 1
   scan
   call Setup
   call Play
wend

sub Setup
   ' clear arrays and variables
   dim shipX(10), shipY(10), shipHor(10), shipHits$(10), shipSunk(10) ' not using 0 index
   dim p(9, 9), c(9, 9)
   ' for Computer AI
   dim hits(9, 9), hitx(81), hity(81)
   dir = 0: currentHits = 0: pTurn = 0: GameOn = 0: ColA = -1 ' globals
   cls
   ' Game Board draw once per game
   Print ""
   Print "          Player                    Computer"
   Print ""
   Print "    A B C D E F G H I J        A B C D E F G H I J"
   Print "    -------------------        -------------------"
   Print " 0| . . . . . . . . . .     0| . . . . . . . . . ."
   Print " 1| . . . . . . . . . .     1| . . . . . . . . . ."
   Print " 2| . . . . . . . . . .     2| . . . . . . . . . ."
   Print " 3| . . . . . . . . . .     3| . . . . . . . . . .   Ships:     P C"
   Print " 4| . . . . . . . . . .     4| . . . . . . . . . .   Carrier    . ."
   Print " 5| . . . . . . . . . .     5| . . . . . . . . . .   Battleship . ."
   Print " 6| . . . . . . . . . .     6| . . . . . . . . . .   Cruiser    . ."
   Print " 7| . . . . . . . . . .     7| . . . . . . . . . .   Submarine  . ."
   Print " 8| . . . . . . . . . .     8| . . . . . . . . . .   Destroyer  . ."
   Print " 9| . . . . . . . . . .     9| . . . . . . . . . ."
   Print "    -------------------        -------------------"
   Print "    A B C D E F G H I J        A B C D E F G H I J"
   'locate 5, 6: print "X" ' check offsets
   For i = 1 To 10
       shipHits$(i) = String$(shipLen(i), "o")
   Next
   call autosetup 1
   call message "Let computer setup your ships?  press y for yes, n for no..."
   k$ = Input$(1)
   If k$ = "y" Then
       call autosetup 0
   Else
       For S = 1 To 5
           OK = 0
           locate 1, 21
           print "To place ship:"+chr$(13)+"Enter v for vertical, h for horizontal, letter and digit for top, left of ship"
           While OK = 0
               call clearMessage
               call message "Setting up the ";shipName$(S);" with length ";shipLen(S)
               Locate 1, 23: Print Space$(80);
               locate 1, 23: input "placement? "; place$
               place$ = upper$(place$)
               If Left$(place$, 1) = "V" Then shipHor(S) = 0 Else shipHor(S) = 1
               sx = InStr("ABCDEFGHIJ", Mid$(place$, 2, 1)) -1
               sy = val(mid$(place$, 3, 1))
               locate 1, 23: print space$(80);
               If shipHor(S) Then
                   If sx <= 10 - shipLen(S) Then
                       OK = 1
                       For xx = 0 To shipLen(S) - 1
                           If p(sx + xx, sy) <> 0 Then OK = 0: Exit For
                       Next
                       If OK Then
                           shipX(S) = sx: shipY(S) = sy
                           For xx = 0 To shipLen(S) - 1
                               p(sx + xx, sy) = S
                               call LP sx + xx, sy, "p", str$(S)
                           Next
                       End If
                   End If
               Else
                   If sy <= 10 - shipLen(S) Then
                       OK = 1
                       For yy = 0 To shipLen(S) - 1
                           If p(sx, sy + yy) <> 0 Then OK = 0: Exit For
                       Next
                       If OK Then
                           shipX(S) = sx: shipY(S) = sy
                           For yy = 0 To shipLen(S) - 1
                               p(sx, sy + yy) = S
                               call LP sx, sy + yy, "p", str$(S)
                           Next
                       End If
                   End If
               End If
           Wend
       Next
       locate 1, 21: print space$(80);
       locate 1, 22: print space$(80);
       locate 1, 23: print space$(80);
   End If
   call clearMessage
end sub

Sub autosetup AItf '  there is surely a shorter way to do this but I am eager to get on with other stuff
   If AItf Then 'setup Computer's ships
       'setup a board with ships, Computer or AI's setup
       For S = 6 To 10
           OK = 0
           While OK = 0
               shipHor(S) = rand(0, 1)
               If shipHor(S) Then
                   sy = rand(0, 9)
                   sx = rand(0, 10 - shipLen(S))
                   OK = 1
                   For xx = 0 To shipLen(S) - 1
                       If c(sx + xx, sy) <> 0 Then OK = 0: Exit For
                   Next
                   If OK Then
                       shipX(S) = sx: shipY(S) = sy
                       For xx = 0 To shipLen(S) - 1
                           c(sx + xx, sy) = S
                           'call LP sx + xx, sy, "c", str$(S mod 10) ' for debugg
                       Next
                   End If
               Else
                   sx = rand(0, 9)
                   sy = rand(0, 10 - shipLen(S))
                   OK = 1
                   For yy = 0 To shipLen(S) - 1
                       If c(sx, sy + yy) <> 0 Then OK = 0: Exit For
                   Next
                   If OK Then
                       shipX(S) = sx: shipY(S) = sy
                       For yy = 0 To shipLen(S) - 1
                           c(sx, sy + yy) = S
                           'call LP sx, sy + yy, "c", str$(S mod 10) ' for debugg
                       Next
                   End If
               End If
           Wend
       Next
   Else 'setup Player's ships
       For S = 1 to 5
           OK = 0
           While OK = 0
               shipHor(S) = rand(0, 1)
               If shipHor(S) Then
                   sy = rand(0, 9)
                   sx = rand(0, 10 - shipLen(S))
                   OK = 1
                   For xx = 0 To shipLen(S) - 1
                       If p(sx + xx, sy) <> 0 Then OK = 0: Exit For
                   Next
                   If OK Then
                       shipX(S) = sx: shipY(S) = sy
                       For xx = 0 To shipLen(S) - 1
                           p(sx + xx, sy) = S
                           call LP sx + xx, sy, "p", str$(S)
                       Next
                   End If
               Else
                   sx = rand(0, 9)
                   sy = rand(0, 10 - shipLen(S))
                   OK = 1
                   For yy = 0 To shipLen(S) - 1
                       If p(sx, sy + yy) <> 0 Then OK = 0: Exit For
                   Next
                   If OK Then
                       shipX(S) = sx: shipY(S) = sy
                       For yy = 0 To shipLen(S) - 1
                           p(sx, sy + yy) = S
                           call LP sx, sy + yy, "p", str$(S)
                       Next
                   End If
               End If
           Wend
       Next
   End If
End Sub

sub message m$
   locate 1, 20: print m$;
end sub

sub clearMessage
   locate 1, 20: print space$(80);
   locate 1, 20: print ""
end sub

sub LP x, y, pcGrid$, s$
if pcGrid$ = "p" then locate PXO + 2 * x, PYO + y else locate CXO + 2 * x, CYO + y
Print s$;
end sub

function rand(low, high) ' Random integer from low to high inclusive
   rand = int(rnd(0) * (high - low + 1)) + low
end function

sub Play
   GameOn = 1
   While GameOn
       scan
       'call updateStatus ' really needed here?
       If pTurn Then pTurn = 0 Else pTurn = 1
       If pTurn Then
           Locate 1, 20: Input "Enter your next bomb site letter digit "; place$
           If place$ = "" Then GameOn = 0
           place$ = upper$(place$)
           bx = instr("ABCDEFGHIJ", left$(place$, 1)) - 1
           by = val(mid$(place$, 2, 1))
           if bx >= 0 and bx < 10 then ' better check
               if by >= 0 and by < 10 then
                   If c(bx, by) <> 0 Then 'hit
                       call LP bx, by, "c", "X"
                       call hitEval "c", bx, by 'game could end here
                   Else
                       call LP bx, by, "c", "o"
                   End If
               end if
           end if
           call clearMessage
       Else
           'AI's turn if it gets a hit it will bomb around the ship until it is finished
           'could be trouble if 2 ships are next to each other, damn until just now I hadn't anticipated this
           'hits board tracks red and white pegs like a human player for AI
           If dir Then 'we have a bomb location all set to test
               If p(bombx, bomby) <> 0 Then 'hit!
                   hit2 = 1
                   hits(bombx, bomby) = 1: currentHits = currentHits + 1
                   ihit = ihit + 1
                   hitx(ihit) = bombx
                   hity(ihit) = bomby
                   call LP bombx, bomby, "p", "X"

                   'we need to know stuff but can't use this info for AI finding the ship
                   'when hitEval announces a ship sunk we can reduce the currentHits count by that ships amount
                   'if still have more current hits, continue bombing area as another ship is there
                   call hitEval "p", bombx, bomby 'this will reduce currentHits by the amount a ship could take when sunk
                   If currentHits = 0 Then 'clear our checklist we sank all ships we hit, call off bombing of area
                       x1 = 0: y1 = 0: dir = 0
                   Else
                       call decideWhereToBombNext
                   End If
               Else 'no hit from checklist scratch off one item
                   hit2 = 0
                   hits(bombx, bomby) = -1
                   call LP bombx, bomby, "p", "o"
                   call decideWhereToBombNext
               End If ' are we still working on hit
           Else
               'not working on any hits x1, y1 = 0, dir = 0, currentHits might be = 0
               'random but systematic shooting, bring up next good shooting location

               call shoot ' new sub added sets row and col to bomb
               'consider that shot just fired was it a hit or miss

               If p(col, row) <> 0 Then ' test our shot just fired is hit!
                   x1 = col: y1 = row 'save first hit to come back to
                   hits(x1, y1) = 1
                   currentHits = currentHits + 1
                   call LP x1, y1, "p", "X"
                   'we need to know stuff but can't use this info for AI finding the ship
                   'it's the same as for the player
                   call hitEval "p", x1, y1
                   'did we just happen to finish off a ship?  current hits = 0
                   If currentHits = 0 Then 'must of finished off an ship
                       x1 = 0: y1 = 0: dir = 0 'we are done
                   Else
                       dir = -1
                       call decideWhereToBombNext
                   End If
               Else 'no hit
                   hits(col, row) = -1
                   call LP col, row, "p", "o"
               End If
           End If 'rI was hit or not
       End If 'whose turn is it
       call pause 1000
   Wend
   call message "Play Again? press y for yes, n for no..."
   k$ = input$(1)
   cls
   if k$ = "n" then end
end sub

Sub hitEval board$, bbx, bby
   'this is like a referee / judge for both players  to announce a ship sunk and a game won?
   'notice "hitEval"+chr$(13)+board$+", bx,by" + str$(bbx) +", "+str$(bby)
   If board$ <> "p" Then
       S = c(bbx, bby) ' which ship number
       you$ = "Player"
       my$ = "Computer's"
       istart = 6
       istop = 10
   Else
       S = p(bbx, bby)
       you$ = "Computer"
       my$ = "Player's"
       istart = 1
       istop = 5
   End If
   If shipHor(S) Then d = bbx - shipX(S) + 1 Else d = bby - shipY(S) + 1
   'notice "s d = "+chr$(13) + str$(S) + ", "+str$(d)
   shipHits$(S) = SubStr$(shipHits$(S), d, "X")
   'notice "shipHits$ S"+Chr$(13)+shipHits$(S) + " "+str$(S)
   If shipHits$(S) = String$(shipLen(S), "X") Then
       shipSunk(S) = 1
       If board$ = "p" Then currentHits = currentHits - shipLen(S)
       call updateStatus
       notice you$ + " sank " + my$ + " " + shipName$(S); "!"
       tot = 0
       For i = istart To istop
           If shipSunk(i) = 1 Then tot = tot + 1
       Next
       If tot = 5 Then
           call updateStatus
           if you$ = "Computer" then call ShowComputersShips
           Notice "Congratulations " + you$ + ", you sank all " + my$ + " ships! GameOver..."
           GameOn = 0
       End If
   End If
End Sub

Sub decideWhereToBombNext
   'find next good location, mark the direction we took
   If dir = -1 Then '    we just got a fresh hit the rest of the ship is in 1 of 4 directions
       'fresh slate
       Dim hitx(81): ReDim hity(81): ihit = 0: rehit = 0
       [redirect]
       hit2 = 0 'when direction = 0 reset 2nd hit signal to 0
       If x1 + 1 <= 9 Then
           If hits(x1 + 1, y1) = 0 Then
               bombx = x1 + 1: bomby = y1: dir = 1: Exit Sub
           End If
       End If
       If x1 - 1 >= 0 Then
           If hits(x1 - 1, y1) = 0 Then
               bombx = x1 - 1: bomby = y1: dir = 3: Exit Sub
           End If
       End If
       'still here?
       If y1 + 1 <= 9 Then
           If hits(x1, y1 + 1) = 0 Then
               bombx = x1: bomby = y1 + 1: dir = 2: Exit Sub
           End If
       End If
       'still here OK this has to do it!
       If y1 - 1 >= 0 Then
           If hits(x1, y1 - 1) = 0 Then
               bombx = x1: bomby = y1 - 1: dir = 4: Exit Sub
           End If
       End If
       'still here ???? damn! give up and go back to random shots
       rehit = rehit + 1
       if rehit > ihit then
           dir = 0: Exit Sub '   <    this signals that
       else
           x1 = hitx(rehit): y1 = hity(rehit)
           GoTo [redirect]
       end if
       dir = 0: Exit Sub
   End If

   'setup next bombx, bomby
   If hit2 Then 'whatever direction we are taking, continue if we can
       Select Case dir
           Case 1
               If bombx + 1 <= 9 Then
                   If hits(bombx + 1, bomby) = 0 Then
                       bombx = bombx + 1: Exit Sub
                   End If
               End If
           Case 2
               If bomby + 1 <= 9 Then
                   If hits(bombx, bomby + 1) = 0 Then
                       bomby = bomby + 1: Exit Sub
                   End If
               End If
           Case 3
               If bombx - 1 >= 0 Then
                   If hits(bombx - 1, bomby) = 0 Then
                       bombx = bombx - 1: Exit Sub
                   End If
               End If
           Case 4
               If bomby - 1 >= 0 Then
                   If hits(bombx, bomby - 1) = 0 Then
                       bomby = bomby - 1: dir = 4: Exit Sub
                   End If
               End If
       End Select
   End If

   'still here? then we have to change direction  and go back to x1, y1 the first hit
   hit2 = 0 'reset this for the new direction check
   While dir < 4 and dir > 0
       ' dir = dir + 1 try 180 direction
       select case dir
           case 1 : dir = 3
           case 2 : dir = 4
           case 3 : dir = 2
           case 4 ' at the end of the rope
               rehit = rehit + 1
               If rehit > ihit Then
                   dir = 0: Exit Sub 'back to random bombing
               Else
                   x1 = hitx(rehit): y1 = hity(rehit)
                   GoTo [redirect]
               End If
       End select
       Select Case dir
           Case 2
               If y1 + 1 <= 9 Then
                   If hits(x1, y1 + 1) = 0 Then
                       bombx = x1: bomby = y1 + 1: Exit Sub
                   End If
               End If
           Case 3
               If x1 - 1 >= 0 Then
                   If hits(x1 - 1, y1) = 0 Then
                       bombx = x1 - 1: bomby = y1: Exit Sub
                   End If
               End If
           Case 4
               If y1 - 1 >= 0 Then
                   If hits(x1, y1 - 1) = 0 Then
                       bombx = x1: bomby = y1 - 1: Exit Sub
                   End If
               End If
       End Select
   Wend
   'still here, well we've run out of directions
   rehit = rehit + 1
   if rehit > ihit then
       dir = 0 : exit sub
   else
       x1 = hitx(rehit): y1 = hity(rehit)
       goto [redirect]
   end if
   'dir = 0 'back to random bombing
End Sub

function SubStr$(s$, place, subst$)
   for i = 1 to len(s$)
       if i = place then r$ = r$ + subst$ else r$ = r$ + mid$(s$, i, 1)
   next
   SubStr$ = r$
end function

function String$(number, s$)
   for i = 1 to number
       r$ = r$ + s$
   next
   String$ = r$
end function

Sub updateStatus ' ships area
   For i = 1 To 5 ' row 10 carrier player colum 66 computer column 68
       If shipSunk(i) Then Locate 65, i + 9:  Print "X";
       If shipSunk(i + 5) Then Locate 67, i + 9: Print "X"
   Next
End Sub

sub ShowComputersShips
   For S = 6 To 10
       If shipHor(S) Then
           sx = shipX(S): sy = shipY(S)
           For xx = 0 To shipLen(S) - 1
               call LP sx + xx, sy, "c", str$(S mod 10) ' for debugg
           Next
       Else
           sx = shipX(S) : sy = shipY(S)
           For yy = 0 To shipLen(S) - 1
               call LP sx, sy + yy, "c", str$(S mod 10) ' for debugg
           Next
       End If
   Next
end sub

Sub shoot ' sets Globals col, row for bombing
   i = 5 'start with players destroyer
   While shipSunk(i) 'find smallest ship not sunk
       i = i - 1
   Wend
   Select Case i 'm for modulus, d for direction to run a check from
       Case 5: m = 3 'still have destroyer, for more exciting game testng m = 3
       Case 4: m = 3 'still have sub
       Case 3: m = 3 'still have cruiser
       Case 2: m = 4 'still have battleship
       Case 1: m = 5 'still have carrier
   End Select
   bc = 0
   If colA = -1 Then 'col the Attact starts from notice it is random so player can't anticipate
       colA = rand(0, 9): col = colA: row = rand(0, 9): bump = rand(0, m - 1)
   End If
   While bc < m
       cc = 1
       While cc <= 10
           rc = 0
           while rc <= 10 'find a space to hit if one left in this column
               If cover(m, bump, col, row) Then 'are we on a place to cover board
                   If hits(col, row) = 0 Then Exit Sub 'good to go!
               End If
               row = (row + 1) Mod 10
               rc = rc + 1
           Wend
           row = row - 1
           If row < 0 Then row = 9
           'still here means we checked all rows in col so check next col
           col = (col + 1) Mod 10
           cc = cc + 1
       Wend
       'still here ? then up the bump
       bump = (bump + 1) Mod m
       bc = bc + 1
   Wend
End Sub

'using a modulus m coverage with a bump so that opponent can't predict where
'the hardest place to plant the Detroyer
Function cover (m, bump, c, r)
   bm = bump Mod m 'make sure bump is in modulus
   cm = (c + bm) Mod m
   rm = r Mod m
   If rm = cm Then cover = -1 Else cover = 0
End Function

sub pause mil   'tsh version has scan built-in
   t0 = time$("ms")
   while time$("ms") < t0 + mil : scan : wend
end sub


EDIT: Found error in decideWhereToBombNext about 8 hours since first posted. I was playing a game with one ship end parked at bottom of screen Carrier the computer hit 4 of 5 spots on ship and stopped it's attack, it was the last hit for win and it never finished off the ship but stupidly shot every other place not shot yet. Turns out the check if y + 1 <= edge then shot but number was 1 short! So that is fixed now in code above.

[plus]

I've got another AI update! What I call Mod842 but I may be boring you guys... ?

I have to look up difference between passion and obsession. I think it is passion but might be one no one else has.
It being my fascination with trying different AI's for this game, I mean who cares about jazzing it up with sound and images, bling to make it noisey and shiney. All I care about is the code that makes my opponent the computer appear really quite intelligent!

Could be obsession, which sounds bad ;-))



b = b + ...

[plus]

? Quick question to JB experts,

Quickest way to get a sound to indicate the computer hit a ship, to alert the player of potential impending doom if he pays too much attention to his own bombing pattern. As I recall no BEEP for JB.

b = b + ...

[tenochtitlanuk]

PLAYWAVE

PLAYWAVE "filename" [, mode ]

Description:

This plays a *.wav sound from a file on disk as specified in filename. If mode is specified, it must be one of the modes described below:

 sync (or synch)- wait for the wave file to finish playing (the default)
 async (or asynch) - don't wait for the wave file to finish playing
 loop- play the wave file over and over (cancel with: playwave "")

Usage

 playwave "ding.wav", async
 playwave "tada.wav"
 playwave "hello.wav", loop
 playwave "" 'to stop previous wav from playing

[plus]

Thankyou john tenochtitlanuk I just got done debugging my blunders in version Mod842, sounds when hit a ship much needed.

Update: well they all sound the same to me! LOL at least we have some audio indication of a hit.
EDIT: turns out we are hearing an error ding from Windows, but works for me just need some audible when a bomb hits a ship.

Mod842
' Battleship Mod842 b+ 2024-07-25 uses a garanteed AI to find Destroyer in 50 shots
' unlike Battleship 2 which AI uses mod 3 it is screwed if fails to find Destroyer when mod 3 shooting
' covers the ocean taking something like up to 66 shots to garantee finding Destroyer.
' 2024-07-26 some improvements when showing where computer ships were if it wins, show only parts not shot.
' add sounds for when a ship gets tada for when player gets computer ship, ding when computer gets your ship.
' Thanks John T and again thanks to tsh73 who got me inspired for restarting Battleship AI experiments.

' This code starts from my first Battleship coded for JB:
' Battleship based on Hasbro Game b+ 2024-07-23 allot of code ported out of old QB64 version

Global PXO, PYO, CXO, CYO, SXO, SYO
Global dir, aiI, currentHits, pTurn, GameOn ' preserve between AI calls
Global x1, y1, bombx, bomby, hit2
'''''''''''''''''''''''''''''''''' Set Once and forget it! '''''''''''''''''
PXO = 5  : PYO = 6 ' offsets for player grid
CXO = 32 : CYO = 6 ' offsets for computer grid player shoots at
SXO = 65 : SYO = 10 ' offsets ship tally
DIM shipLen(10), shipName$(10), AIshots$(50)
For i = 1 To 10 ' not sure I need names yet
   Select Case i
       Case 1: shipLen(i) = 5: shipName$(i) = "Carrier"
       Case 2: shipLen(i) = 4: shipName$(i) = "Battleship"
       Case 3: shipLen(i) = 3: shipName$(i) = "Cruiser"
       Case 4: shipLen(i) = 3: shipName$(i) = "Submarine"
       Case 5: shipLen(i) = 2: shipName$(i) = "Destroyer"
       Case 6: shipLen(i) = 5: shipName$(i) = "Carrier"
       Case 7: shipLen(i) = 4: shipName$(i) = "Battleship"
       Case 8: shipLen(i) = 3: shipName$(i) = "Cruiser"
       Case 9: shipLen(i) = 3: shipName$(i) = "Submarine"
       Case 10: shipLen(i) = 2: shipName$(i) = "Destroyer"
   End Select
Next
dim t(50) ' shuffle see Setup
for i = 1 to 50 : t(i) = i : next

while 1 'run game loop until player quits
   scan
   call Setup
   call Shoot
wend

sub Setup
   ' clear arrays and variables
   dim shipX(10), shipY(10), shipHor(10), shipHits$(10), shipSunk(10) ' not using 0 index
   dim p(9, 9), c(9, 9)
   pTurn = 0: GameOn = 0 ' globals
   ' for Computer AI
   dim hits(9, 9)
   dir = 0: aiI = 0: currentHits = 0 ' globals

       'setup 2 bombing patterns to cover sea in checkerboard pattern one is chosen in each game
   s1$ = "A0B1C2D3E4F5G6H7I8J9I0J1A8B9E0F1G2H3I4J5A4B5C6D7E8F9C0D1E2F3G4H5I6J7A6B7C8D9G0H1I2J3A2B3C4D5E6F7G8H9"
   s2$ = "A9B8C7D6E5F4G3H2I1J0B0A1I9J8A5B4C3D2E1F0E9F8G7H6I5J4A3B2C1D0A7B6C5D4E3F2G1H0C9D8E7F6G5H4I3J2G9H8I7J6"
   If Rnd(0) < .5 Then shots$ = s1$ Else shots$ = s2$ ' don't be predictable with bombing patterns
   ' shuffle sections: priority diagonal then sub diagonals, Mod 8 then mod 4 then mod 2
   start = 1 : stp = 10 : call shuff start, stp
   start = 11 :stp = 14 : call shuff start, stp
   start = 15 :stp = 26 : call shuff start, stp
   start = 27 :stp = 50 : call shuff start, stp
   for i = 1 to 50 ' stow into an array
       AIshots$(i) = Mid$(shots$, 2 * t(i) - 1, 2)
   next
   cls
   ' Game Board draw once per game
   Print ""
   Print "          Player                    Computer"
   Print ""
   Print "    A B C D E F G H I J        A B C D E F G H I J"
   Print "    -------------------        -------------------"
   Print " 0| . . . . . . . . . .     0| . . . . . . . . . ."
   Print " 1| . . . . . . . . . .     1| . . . . . . . . . ."
   Print " 2| . . . . . . . . . .     2| . . . . . . . . . ."
   Print " 3| . . . . . . . . . .     3| . . . . . . . . . .   Ships:     P C"
   Print " 4| . . . . . . . . . .     4| . . . . . . . . . .   Carrier    . ."
   Print " 5| . . . . . . . . . .     5| . . . . . . . . . .   Battleship . ."
   Print " 6| . . . . . . . . . .     6| . . . . . . . . . .   Cruiser    . ."
   Print " 7| . . . . . . . . . .     7| . . . . . . . . . .   Submarine  . ."
   Print " 8| . . . . . . . . . .     8| . . . . . . . . . .   Destroyer  . ."
   Print " 9| . . . . . . . . . .     9| . . . . . . . . . ."
   Print "    -------------------        -------------------"
   Print "    A B C D E F G H I J        A B C D E F G H I J"
   'locate 5, 6: print "X" ' check offsets
   ' check AIshots$((aiI) OK
   'for i = 1 to 50 'double check checker board coverage 50 cells in priority order
   '    x = instr("ABCDEFGHIJ", left$(AIshots$(i), 1)) - 1
   '    y = val(mid$(AIshots$(i), 2, 1))
   '    call LP x, y, "p", "O"
   '    call pause 500
   'next
   For i = 1 To 10 ' restring ship hits
       shipHits$(i) = String$(shipLen(i), "o")
   Next
   call autosetup 1
   call message "Let computer setup your ships?  press y for yes, n for no..."
   k$ = Input$(1)
   If k$ = "y" Then
       call autosetup 0
   Else
       For S = 1 To 5 ' do it yourself ship placement
           OK = 0
           locate 1, 21
           print "To place ship:"+chr$(13)+"Enter v for vertical, h for horizontal, letter and digit for top, left of ship"
           While OK = 0
               call clearMessage
               call message "Setting up the ";shipName$(S);" with length ";shipLen(S)
               Locate 1, 23: Print Space$(80);
               locate 1, 23: input "placement? "; place$
               place$ = upper$(place$)
               If Left$(place$, 1) = "V" Then shipHor(S) = 0 Else shipHor(S) = 1
               sx = InStr("ABCDEFGHIJ", Mid$(place$, 2, 1)) -1
               sy = val(mid$(place$, 3, 1))
               locate 1, 23: print space$(80);
               If shipHor(S) Then
                   If sx <= 10 - shipLen(S) Then
                       OK = 1
                       For xx = 0 To shipLen(S) - 1
                           If p(sx + xx, sy) <> 0 Then OK = 0: Exit For
                       Next
                       If OK Then
                           shipX(S) = sx: shipY(S) = sy
                           For xx = 0 To shipLen(S) - 1
                               p(sx + xx, sy) = S
                               call LP sx + xx, sy, "p", str$(S)
                           Next
                       End If
                   End If
               Else
                   If sy <= 10 - shipLen(S) Then
                       OK = 1
                       For yy = 0 To shipLen(S) - 1
                           If p(sx, sy + yy) <> 0 Then OK = 0: Exit For
                       Next
                       If OK Then
                           shipX(S) = sx: shipY(S) = sy
                           For yy = 0 To shipLen(S) - 1
                               p(sx, sy + yy) = S
                               call LP sx, sy + yy, "p", str$(S)
                           Next
                       End If
                   End If
               End If
           Wend
       Next
       locate 1, 21: print space$(80);  ' clear multi-lines
       locate 1, 22: print space$(80);
       locate 1, 23: print space$(80);
   End If
   call clearMessage
end sub

Sub autosetup AItf '  there is surely a shorter way to do this but I am eager to get on with other stuff
   If AItf Then 'setup Computer's ships
       'setup a board with ships, Computer or AI's setup
       For S = 6 To 10
           OK = 0
           While OK = 0
               shipHor(S) = rand(0, 1)
               If shipHor(S) Then
                   sy = rand(0, 9)
                   sx = rand(0, 10 - shipLen(S))
                   OK = 1
                   For xx = 0 To shipLen(S) - 1
                       If c(sx + xx, sy) <> 0 Then OK = 0: Exit For
                   Next
                   If OK Then
                       shipX(S) = sx: shipY(S) = sy
                       For xx = 0 To shipLen(S) - 1
                           c(sx + xx, sy) = S
                           'call LP sx + xx, sy, "c", str$(S mod 10) ' for debugg
                       Next
                   End If
               Else
                   sx = rand(0, 9)
                   sy = rand(0, 10 - shipLen(S))
                   OK = 1
                   For yy = 0 To shipLen(S) - 1
                       If c(sx, sy + yy) <> 0 Then OK = 0: Exit For
                   Next
                   If OK Then
                       shipX(S) = sx: shipY(S) = sy
                       For yy = 0 To shipLen(S) - 1
                           c(sx, sy + yy) = S
                           'call LP sx, sy + yy, "c", str$(S mod 10) ' for debugg
                       Next
                   End If
               End If
           Wend
       Next
   Else 'setup Player's ships
       For S = 1 to 5
           OK = 0
           While OK = 0
               shipHor(S) = rand(0, 1)
               If shipHor(S) Then
                   sy = rand(0, 9)
                   sx = rand(0, 10 - shipLen(S))
                   OK = 1
                   For xx = 0 To shipLen(S) - 1
                       If p(sx + xx, sy) <> 0 Then OK = 0: Exit For
                   Next
                   If OK Then
                       shipX(S) = sx: shipY(S) = sy
                       For xx = 0 To shipLen(S) - 1
                           p(sx + xx, sy) = S
                           call LP sx + xx, sy, "p", str$(S)
                       Next
                   End If
               Else
                   sx = rand(0, 9)
                   sy = rand(0, 10 - shipLen(S))
                   OK = 1
                   For yy = 0 To shipLen(S) - 1
                       If p(sx, sy + yy) <> 0 Then OK = 0: Exit For
                   Next
                   If OK Then
                       shipX(S) = sx: shipY(S) = sy
                       For yy = 0 To shipLen(S) - 1
                           p(sx, sy + yy) = S
                           call LP sx, sy + yy, "p", str$(S)
                       Next
                   End If
               End If
           Wend
       Next
   End If
End Sub

sub message m$
   locate 1, 20: print m$;
end sub

sub clearMessage
   locate 1, 20: print space$(80);
   locate 1, 20: print ""
end sub

sub LP x, y, pcGrid$, s$
   if pcGrid$ = "p" then locate PXO + 2 * x, PYO + y else locate CXO + 2 * x, CYO + y
   Print s$;
end sub

function rand(low, high) ' Random integer from low to high inclusive
   rand = int(rnd(0) * (high - low + 1)) + low
end function

sub Shoot
   GameOn = 1
   While GameOn
       scan
       If pTurn Then pTurn = 0 Else pTurn = 1
       If pTurn Then ' player
           Locate 1, 20: Input "Enter your next bomb site letter digit "; place$
           If place$ = "" Then GameOn = 0
           place$ = upper$(place$)
           bx = instr("ABCDEFGHIJ", left$(place$, 1)) - 1
           by = val(mid$(place$, 2, 1))
           if bx >= 0 and bx < 10 then ' better check
               if by >= 0 and by < 10 then
                   If c(bx, by) <> 0 Then 'hit
                       call LP bx, by, "c", "X"
                       call hitEval "c", bx, by 'game could end here
                   Else
                       call LP bx, by, "c", "o"
                   End If
               end if
           end if
           call clearMessage
       Else
           'AI's turn if it gets a hit it will bomb around the ship until it is finished
           'could be trouble if 2 ships are next to each other. Some effort to work it, still might get confused.
           'hits() array tracks red = 1 and white pegs = -1 like a human player for AI

           If dir Then 'we are working around the latest hit with bombx, bomby to test
               If p(bombx, bomby) <> 0 Then 'hit!
                   hit2 = 1
                   hits(bombx, bomby) = 1: currentHits = currentHits + 1
                   call LP bombx, bomby, "p", "X"

                   'we need to know stuff but can't use this info for AI finding the ship
                   'when hitEval announces a ship sunk we can reduce the currentHits count by that ships amount
                   'if still have more current hits, continue bombing area as another ship is there
                   call hitEval "p", bombx, bomby 'this will reduce currentHits by the amount a ship could take when sunk
                   If currentHits = 0 Then 'clear our checklist we sank all ships we hit, call off bombing of area
                       x1 = 0: y1 = 0: dir = 0
                   Else
                       call decideWhereToBombNext
                   End If
               Else 'no hit from checklist scratch off one item
                   hit2 = 0
                   hits(bombx, bomby) = -1
                   call LP bombx, bomby, "p", "o"
                   call decideWhereToBombNext
               End If ' are we still working on hit

           Else
               'not working on any hits x1, y1 = 0, dir = 0, currentHits might be = 0
               'random but systematic shooting, bring up next good shooting location
               [alreadyHit]
               aiI = aiI + 1 ' next random shoot
               if aiI > 50 then  ' we should never get this far but just in case
                   x = rand(0, 9)
                   y = rand(0, 9)
               else ' normal shooting pattern by diagonals to form checker board coverage
                   x = instr("ABCDEFGHIJ", left$(AIshots$(aiI), 1)) - 1
                   y = val(mid$(AIshots$(aiI), 2, 1))
               end if
               if hits(x, y) <> 0 then goto [alreadyHit]

               ' was that shot just fired a hit or miss
               If p(x, y) <> 0 Then ' test our shot just fired is hit!
                   x1 = x: y1 = y 'save first hit to come back to
                   hits(x1, y1) = 1: currentHits = currentHits + 1
                   call LP x1, y1, "p", "X"
                   ' we need to know stuff but can't use this info for AI finding the ship
                   ' keep the same as for the player
                   call hitEval "p", x1, y1
                   'did we just happen to finish off a ship?  current hits = 0
                   If currentHits = 0 Then 'must of finished off an ship
                       x1 = 0: y1 = 0: dir = 0 'we are done
                   Else
                       dir = -1 ' this signals we are working on a hit
                       call decideWhereToBombNext
                   End If
               Else 'no hit
                   hits(x, y) = -1
                   call LP x, y, "p", "o"
               End If
           End If 'rI was hit or not
       End If 'whose turn is it
       call pause 1500 ' a sec pause to allow us to see computers move
   Wend
   call message "Play Again? press y for yes, n for no..."
   k$ = input$(1)
   cls
   if k$ = "n" then end
end sub

Sub hitEval board$, bbx, bby  ' hmm I could have used Global pTurn and not pass board$
   'this is like a referee for both players to announce a ship sunk and a game won?
   If board$ <> "p" Then
       playwave "ding.wav"
       S = c(bbx, bby) ' which ship number
       you$ = "Player"
       my$ = "Computer's"
       istart = 6
       istop = 10
   Else
       playwave "hello.wav" ' tada sounds same as ding
       S = p(bbx, bby)
       you$ = "Computer"
       my$ = "Player's"
       istart = 1
       istop = 5
   End If
   If shipHor(S) Then d = bbx - shipX(S) + 1 Else d = bby - shipY(S) + 1
   shipHits$(S) = SubStr$(shipHits$(S), d, "X")
   If shipHits$(S) = String$(shipLen(S), "X") Then
       shipSunk(S) = 1
       If board$ = "p" Then currentHits = currentHits - shipLen(S)
       call updateStatus
       notice you$ + " sank " + my$ + " " + shipName$(S); "!"
       tot = 0
       For i = istart To istop
           If shipSunk(i) = 1 Then tot = tot + 1
       Next
       If tot = 5 Then
           call updateStatus ' might not need this call

           if you$ = "Computer" then call ShowComputersShips ' not seeing ??? test again missed again


           Notice "Congratulations " + you$ + ", you sank all " + my$ + " ships! GameOver..."
           GameOn = 0
       End If
   End If
End Sub

Sub decideWhereToBombNext
   'find next good location, mark the direction we took
   If dir = -1 Then '
       hit2 = 0 'when direction = 0 reset 2nd hit signal to 0
       If x1 + 1 <= 9 Then
           If hits(x1 + 1, y1) = 0 Then
               bombx = x1 + 1: bomby = y1: dir = 1: Exit Sub
           End If
       End If
       'still here?
       If y1 + 1 <= 9 Then
           If hits(x1, y1 + 1) = 0 Then
               bombx = x1: bomby = y1 + 1: dir = 2: Exit Sub
           End If
       End If
       'still here?
       If x1 - 1 >= 0 Then
           If hits(x1 - 1, y1) = 0 Then
               bombx = x1 - 1: bomby = y1: dir = 3: Exit Sub
           End If
       End If
       'still here OK this has to do it!
       If y1 - 1 >= 0 Then
           If hits(x1, y1 - 1) = 0 Then
               bombx = x1: bomby = y1 - 1: dir = 4: Exit Sub
           End If
       End If
       'still here ???? damn! give up and go back to random shots
       dir = 0: Exit Sub '   <    this signals that
   End If

   'setup next bombx, bomby
   If hit2 Then 'whatever direction we are taking, continue if we can
       Select Case dir
           Case 1
               If bombx + 1 <= 9 Then
                   If hits(bombx + 1, bomby) = 0 Then
                       bombx = bombx + 1: Exit Sub
                   End If
               End If
           Case 2
               If bomby + 1 <= 9 Then
                   If hits(bombx, bomby + 1) = 0 Then
                       bomby = bomby + 1: Exit Sub
                   End If
               End If
           Case 3
               If bombx - 1 >= 0 Then
                   If hits(bombx - 1, bomby) = 0 Then
                       bombx = bombx - 1: Exit Sub
                   End If
               End If
           Case 4
               If bomby - 1 >= 0 Then
                   If hits(bombx, bomby - 1) = 0 Then
                       bomby = bomby - 1: dir = 4: Exit Sub
                   End If
               End If
       End Select
   End If

   'still here? then we have to change direction  and go back to x1, y1 the first hit
   hit2 = 0 'reset this for the new direction check
   While dir < 4
       dir = dir + 1
       Select Case dir
           Case 2
               If y1 + 1 <= 9 Then
                   If hits(x1, y1 + 1) = 0 Then
                       bombx = x1: bomby = y1 + 1: Exit Sub
                   End If
               End If
           Case 3
               If x1 - 1 >= 0 Then
                   If hits(x1 - 1, y1) = 0 Then
                       bombx = x1 - 1: bomby = y1: Exit Sub
                   End If
               End If
           Case 4
               If y1 - 1 >= 0 Then
                   If hits(x1, y1 - 1) = 0 Then
                       bombx = x1: bomby = y1 - 1: Exit Sub
                   End If
               End If
       End Select
   Wend
   'still here, well we've run out of directions
   dir = 0 'back to random bombing
End Sub

function SubStr$(s$, place, subst$)
   for i = 1 to len(s$)
       if i = place then r$ = r$ + subst$ else r$ = r$ + mid$(s$, i, 1)
   next
   SubStr$ = r$
end function

function String$(number, s$)
   for i = 1 to number
       r$ = r$ + s$
   next
   String$ = r$
end function

Sub updateStatus ' ships area
   For i = 1 To 5 ' row 10 carrier player colum 66 computer column 68
       If shipSunk(i) Then Locate 65, i + 9:  Print "X";
       If shipSunk(i + 5) Then Locate 67, i + 9: Print "X"
   Next
End Sub

sub ShowComputersShips
   For S = 6 To 10
       If shipHor(S) Then
           sx = shipX(S): sy = shipY(S)
           For xx = 0 To shipLen(S) - 1
               If Mid$(shipHits$(S), xx + 1, 1) = "o" Then call LP sx + xx, sy, "c", str$(S mod 10)
           Next
       Else
           sx = shipX(S) : sy = shipY(S)
           For yy = 0 To shipLen(S) - 1
               If Mid$(shipHits$(S), yy + 1, 1) = "o" then call LP sx, sy + yy, "c", str$(S mod 10)
           Next
       End If
   Next
end sub

sub pause mil   'tsh version has scan built-in
   t0 = time$("ms")
   while time$("ms") < t0 + mil : scan : wend
end sub

sub shuff start, stp
   for i = stp to start + 1 step -1
       r = rand(start, stp)
       temp = t(i)
       t(i) = t(r)
       t(r) = temp
   next
end sub


The AI for Mod842 uses this fire pattern (or mirror image) for first 26 shots which will find the 2 larger ships Carrier and Battleship if not shooting around a ship to sink it. They can't escape the net, plus it might pickup on more ships hopefully the Destroyer.

The Computer board in image below shows one Image of the AI shooting pattern used on the Player there is another that is the mirror image of it.


Hint: use this ship setup against AI in Mod842 so it's first 14 shots hit nothing. It will still find Carrier and Battleship in next 12 random shots not including the shots taken to sink a ship once found.
Carrier    ve5
Battleship vf0
Cruiser    hh2
Sub        ha7
Destroer   vh8
EDIT: that trick is no longer predictable and could be disasterous if the mirror image of original shot pattern is used.

Mod842 use a mod 8 wave pattern over the board followed by a mod 4 wave pattern followed by a mod 2 every other square so 50 cells are covered when finished and Destroyer is found in that pattern; again these shots aren't counting the ones around a ship to sink it.

EDIT this post has been updateed 7/27 for 2 shot patterns one the mirror image of the other so no more safe hiding of ships in first 10 shots from computer.







b = b + ...

[tsh73]

Update: well they all sound the same to me!

You hear "Windows error sound" for missing file.

Somehow relative paths did not worked for me at first
but now
playwave "media\bump.wav"
saved as
C:\Users\UserName\AppData\Roaming\Just BASIC v2.0\untitled.bas
works fro me.

[Rod]

I have always found it simpler to put the required .wav files in the project folder. A lot less typing. Also you never know where a user might keep the sound files. We can attach such files to these posts so simple distribution is possible.

We do all have the standard file set, I don’t use that very much.

[plus]

Yeah, the beauty I saw in tsh73 code was it's lack of "bling", you get your Basic game without any extra assets to manage. Sure not that hard to have assets files but I just want something sorta pure which is what I saw in tsh73, allot of tsh73 stuff in fact (I am fan more of that and all you guys still here plugging away with Basic code, great source of ideas and enthusiasm for me than JB itself, though it definitely has it's gems too).

What I am trying to say is I am fine with the silly error message ding, that replaces the missing BEEP just fine for me in this case!

And I've already got a change to Mod842 working in the other Basic. Just a couple lines added so you CAN'T use that ship pattern I posted above to hide for awhile from the computers bombing pattern because I randomly select it or the mirror image of it now in BS Mod842.

saved as
C:\Users\UserName\AppData\Roaming\Just BASIC v2.0\untitled.bas
works fro me.

AppData !

That's what I couldn't remember before when looking for the Error Log, but I did remember that the Error Log was not the least helpful for that particular error message.

Hint to @carl if you ever do another update to JB, please, please, please include the line number of the offending error. It would save so much time and hair pulling and frustration... also a shortcut path to the error log would be helpful (maybe in the menu, yes! in the menu!) as well since Windows in its infinitely questionable wisdom no longer lets us even see AppData let alone the crazy unhelpful subdir name Roaming. Sorry for the vent... as I get older, as your entire potential audience and users get older remembering details gets harder specially if JB is not the only Basic one dabbles in... so if you insist or are required by Windows to put stuff in that inaccessible place please give us access from menu and don't make us read a manual to find out where it is. I ask for the future good popularity of JB.



b = b + ...

[plus]

Saturday's post: Battleship Mod842 has been updated for more unpredictable shot pattern against the Player by the Computer. 4 replies up.

b = b + ...

[plus]

Here is my first installment of Battleship Mod842 in Words.txt (I am using my own Editor I built.)
I will use code tags to preserve spacing.
   ' Game Board draw once per game
   Print ""
   Print "             Player                    Computer"
   Print ""
   Print "       A B C D E F G H I J        A B C D E F G H I J"
   Print "       -------------------        -------------------"
   Print "    0| . . . . . . . . . .     0| . . . . . . . . . ."
   Print "    1| . . . . . . . . . .     1| . . . . . . . . . ."
   Print "    2| . . . . . . . . . .     2| . . . . . . . . . ."
   Print "    3| . . . . . . . . . .     3| . . . . . . . . . .   Ships:     P C"
   Print "    4| . . . . . . . . . .     4| . . . . . . . . . .   Carrier    . ."
   Print "    5| . . . . . . . . . .     5| . . . . . . . . . .   Battleship . ."
   Print "    6| . . . . . . . . . .     6| . . . . . . . . . .   Cruiser    . ."
   Print "    7| . . . . . . . . . .     7| . . . . . . . . . .   Submarine  . ."
   Print "    8| . . . . . . . . . .     8| . . . . . . . . . .   Destroyer  . ."
   Print "    9| . . . . . . . . . .     9| . . . . . . . . . ."
   Print "       -------------------        -------------------"
   Print "       A B C D E F G H I J        A B C D E F G H I J"


This is the game board around all coding for Battleship Mod842 is centered.

The Player grid is a numbered array, p() that holds/displays the position of your ships.
The Computer grid is a numbered array c() that tracks your bombs hits "X" are 1 in the
grid and misses "o", -1, places not bombed yet remain "." = 0.

Now the first line of shared vraiables PXO, PYO is the cell col and row for A0 on the
grid, CXO, CYO are the Computer offsets for knowing where to locate X's and o's. And
Ships: SXO, SYO locate to Carrier P the player when these ships are sunk an X fills in
the . cell.

The computer does not have eyes, so it tracks it's hits and misses in the hits() number
array and could care less where it's ships are or how many of it's are sunk compared to
yours.

Now the ship setup:
Dim Shared As Long ShipLen(10), ShipHor(10), ShipX(10), ShipY(10), ShipSunk(10)
Dim Shared ShipName$(10), ShipHits$(10)
' Ship arrays are 0 based but are really numbered 1 to 10, 0 is ignored
' ShipName$() are names of ships according to length in character cells see approx line 38
' ShipLen() is the length or how many character cells a ship is long, 5 down to 2 according to index
' ShipHor() is a T/F value (0|-1) if it is Setup horizontal see SetUp where ships are positioned
' ShipX() and ShipY() locate the top of a ship if vertically set or the left start of ship if horizontal
' ShipHits$() tracks which cell on each ship was hit
' ShipSunk() T/F if ship has been sunk

Here are the types/names of ships and their length in character cells
       Case 1: ShipLen(i) = 5: ShipName$(i) = "Carrier"
       Case 2: ShipLen(i) = 4: ShipName$(i) = "Battleship"
       Case 3: ShipLen(i) = 3: ShipName$(i) = "Cruiser"
       Case 4: ShipLen(i) = 3: ShipName$(i) = "Submarine"
       Case 5: ShipLen(i) = 2: ShipName$(i) = "Destroyer"
       Case 6: ShipLen(i) = 5: ShipName$(i) = "Carrier"
       Case 7: ShipLen(i) = 4: ShipName$(i) = "Battleship"
       Case 8: ShipLen(i) = 3: ShipName$(i) = "Cruiser"
       Case 9: ShipLen(i) = 3: ShipName$(i) = "Submarine"
       Case 10: ShipLen(i) = 2: ShipName$(i) = "Destroyer"
The players ships are numbers 1 to 5 in the ship arrays and the computers are 6-10.

When setting up ships the first crucial piece of info needed either from player or in
the AutoSet routine is whether the ship is to be placed horizontally or vertical,
shipHor() T|F is it horizontal? -1 (anything <>0) yes, 0 no.
The the location is either randomly chosen or the player specifies for his ships.
The location ShipX, ShipY is the left most for horizontal ship or top most for a
vertical ship. From there the code checks that the ship doesn't overlap another and
if OK, lays out the ship as specifies and according to it's numbered length.
Otherwise we loop around and try another location.

Here are some other global variables used in game and zero'd out in SetUp sub.
PTurn = 0: GameOn = 0: Dir = 0: AiI = 0: CurrentHits = 0 ' globals
PTurn is TF (not zero) | 0 number tracks whose turn it is Player or Computer.
GameOn is TF (not zero) | 0 number tracks if the shooting round of game is still
going or all ships sunk for one opponent gameOn = 0, Game is over.

Ha already I see a thousand things to edit, this is going to take awhile but at least I have the ship layout described in SetUp sub.
b = b + ...

[plus]

I was hoping to attack this first thing this morning with fresh mind but got called away for most of the morning.

I am now bulking at the task I have set myself upon... this firstly is started out in too much detail.
Secondly no one has officially asked for it, though tsh73 could rightly do so. that would narrow things down instead of guessing at what people need to know...
And really all I want to get at is how I sink ships once a hit is made.
It would be a good exercise to be able to explain to another so that they can get the jist and do it for themselves in code if so desired, so there is that for our focus. That will take some background setup.

In JB forum, if one does not have specific questions about JB one tends to find oneself doing monologues, hmm...


b = b + ...

[plus]

OK Instead of a boring essay on How the Random Shot Patterns Are Setup, here is The Movie showing the order and pattern set to go for the Computer AI.
' How Random Shots Are Setup
' Battleship Mod842 b+ 2024-07-25 uses a garanteed AI to find Destroyer in 50 shots
' unlike Battleship 2 which AI uses mod 3 it is screwed if fails to find Destroyer when mod 3 shooting
' covers the ocean taking something like up to 66 shots to garantee finding Destroyer.
' 2024-07-26 some improvements when showing where computer ships were if it wins, show only parts not shot.
' add sounds for when a ship gets tada for when player gets computer ship, ding when computer gets your ship.
' Thanks John T and again thanks to tsh73 who got me inspired for restarting Battleship AI experiments.

' This code starts from my first Battleship coded for JB:
' Battleship based on Hasbro Game b+ 2024-07-23 allot of code ported out of old QB64 version

Global PXO, PYO, CXO, CYO, SXO, SYO
Global dir, aiI, currentHits, pTurn, GameOn ' preserve between AI calls
Global x1, y1, bombx, bomby, hit2
'''''''''''''''''''''''''''''''''' Set Once and forget it! '''''''''''''''''
PXO = 5  : PYO = 6 ' offsets for player grid
CXO = 32 : CYO = 6 ' offsets for computer grid player shoots at
SXO = 65 : SYO = 10 ' offsets ship tally
DIM shipLen(10), shipName$(10), AIshots$(50)
For i = 1 To 10 ' not sure I need names yet
   Select Case i
       Case 1: shipLen(i) = 5: shipName$(i) = "Carrier"
       Case 2: shipLen(i) = 4: shipName$(i) = "Battleship"
       Case 3: shipLen(i) = 3: shipName$(i) = "Cruiser"
       Case 4: shipLen(i) = 3: shipName$(i) = "Submarine"
       Case 5: shipLen(i) = 2: shipName$(i) = "Destroyer"
       Case 6: shipLen(i) = 5: shipName$(i) = "Carrier"
       Case 7: shipLen(i) = 4: shipName$(i) = "Battleship"
       Case 8: shipLen(i) = 3: shipName$(i) = "Cruiser"
       Case 9: shipLen(i) = 3: shipName$(i) = "Submarine"
       Case 10: shipLen(i) = 2: shipName$(i) = "Destroyer"
   End Select
Next
dim t(50) ' shuffle see Setup
for i = 1 to 50 : t(i) = i : next

'while 1 'run game loop until player quits
   scan
   call Setup
   'call Shoot
'wend

sub Setup
   ' clear arrays and variables
   dim shipX(10), shipY(10), shipHor(10), shipHits$(10), shipSunk(10) ' not using 0 index
   dim p(9, 9), c(9, 9)
   pTurn = 0: GameOn = 0 ' globals
   ' for Computer AI
   dim hits(9, 9)
   dir = 0: aiI = 0: currentHits = 0 ' globals

       'setup 2 bombing patterns to cover sea in checkerboard pattern one is chosen in each game
   s1$ = "A0B1C2D3E4F5G6H7I8J9I0J1A8B9E0F1G2H3I4J5A4B5C6D7E8F9C0D1E2F3G4H5I6J7A6B7C8D9G0H1I2J3A2B3C4D5E6F7G8H9"
   s2$ = "A9B8C7D6E5F4G3H2I1J0B0A1I9J8A5B4C3D2E1F0E9F8G7H6I5J4A3B2C1D0A7B6C5D4E3F2G1H0C9D8E7F6G5H4I3J2G9H8I7J6"
   If Rnd(0) < .5 Then shots$ = s1$ Else shots$ = s2$ ' don't be predictable with bombing patterns
   ' shuffle sections: priority diagonal then sub diagonals, Mod 8 then mod 4 then mod 2
   start = 1 : stp = 10 : call shuff start, stp
   start = 11 :stp = 14 : call shuff start, stp
   start = 15 :stp = 26 : call shuff start, stp
   start = 27 :stp = 50 : call shuff start, stp
   for i = 1 to 50 ' stow into an array
       AIshots$(i) = Mid$(shots$, 2 * t(i) - 1, 2)
   next
   cls
   ' Game Board draw once per game
   Print ""
   Print "          Player                    Computer"
   Print ""
   Print "    A B C D E F G H I J        A B C D E F G H I J"
   Print "    -------------------        -------------------"
   Print " 0| . . . . . . . . . .     0| . . . . . . . . . ."
   Print " 1| . . . . . . . . . .     1| . . . . . . . . . ."
   Print " 2| . . . . . . . . . .     2| . . . . . . . . . ."
   Print " 3| . . . . . . . . . .     3| . . . . . . . . . .   Ships:     P C"
   Print " 4| . . . . . . . . . .     4| . . . . . . . . . .   Carrier    . ."
   Print " 5| . . . . . . . . . .     5| . . . . . . . . . .   Battleship . ."
   Print " 6| . . . . . . . . . .     6| . . . . . . . . . .   Cruiser    . ."
   Print " 7| . . . . . . . . . .     7| . . . . . . . . . .   Submarine  . ."
   Print " 8| . . . . . . . . . .     8| . . . . . . . . . .   Destroyer  . ."
   Print " 9| . . . . . . . . . .     9| . . . . . . . . . ."
   Print "    -------------------        -------------------"
   Print "    A B C D E F G H I J        A B C D E F G H I J"
   'locate 5, 6: print "X" ' check offsets
   ' check AIshots$((aiI) OK
   for i = 1 to 50 'double check checker board coverage 50 cells in priority order
       x = instr("ABCDEFGHIJ", left$(AIshots$(i), 1)) - 1
       y = val(mid$(AIshots$(i), 2, 1))
       call LP x, y, "p", "O"
       call pause 500
   next
end sub

sub LP x, y, pcGrid$, s$
   if pcGrid$ = "p" then locate PXO + 2 * x, PYO + y else locate CXO + 2 * x, CYO + y
   Print s$;
end sub

function rand(low, high) ' Random integer from low to high inclusive
   rand = int(rnd(0) * (high - low + 1)) + low
end function

sub pause mil   'tsh version has scan built-in
   t0 = time$("ms")
   while time$("ms") < t0 + mil : scan : wend
end sub

sub shuff start, stp
   for i = stp to start + 1 step -1
       r = rand(start, stp)
       temp = t(i)
       t(i) = t(r)
       t(r) = temp
   next
end sub


As you can see how it covers the field of fire in 50 shots and no Destroyer can escape that net.

b = b + ...